Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid D100 for Jupyter Notebooks #8816

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Avoid D100 for Jupyter Notebooks #8816

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78d1fe2
Avoid `D100` for Jupyter Notebooks
dhruvmanila Nov 21, 2023
ec46080
Add test case
dhruvmanila Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions crates/ruff_linter/src/rules/pydocstyle/rules/not_missing.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,6 +534,9 @@ pub(crate) fn not_missing(
kind: ModuleKind::Module,
..
}) => {
if checker.source_type.is_ipynb() {
return true;
}
if checker.enabled(Rule::UndocumentedPublicModule) {
checker.diagnostics.push(Diagnostic::new(
UndocumentedPublicModule,
Expand Down
Loading