Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use line-length setting for isort #8235

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Use line-length setting for isort #8235

merged 1 commit into from
Oct 26, 2023

Conversation

MichaReiser
Copy link
Member

@MichaReiser MichaReiser commented Oct 26, 2023 •
edited
Loading

Summary

I incorrectly changed all line-length usages in the linter to use the pycodestyle.max-line-length setting. However, this is incorrect for isort that should use the same line length as the formatter (to ensure compatibility).

Test Plan

I tested in the playground that setting line-length to a lower limit than pycodestyle.max-line-length raises I001. Increasing the line-length makes the warning disappear again. Verified that E501 continues to use the pycodestyle.max-line-length option.

@MichaReiser
Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@MichaReiser MichaReiser added the configuration Related to settings and configuration label Oct 26, 2023
@MichaReiser MichaReiser linked an issue Oct 26, 2023 that may be closed by this pull request
Change isort to use line-length over pycodestyle.max-line-length #8194
Closed
@MichaReiser MichaReiser marked this pull request as ready for review October 26, 2023 01:16
@MichaReiser MichaReiser merged commit 133a745 into main Oct 26, 2023
16 checks passed
@MichaReiser MichaReiser deleted the isort-use-line-length branch October 26, 2023 01:17
@github-actions
Copy link
Contributor

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

@p-linnane p-linnane mentioned this pull request Oct 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
configuration Related to settings and configuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change isort to use line-length over pycodestyle.max-line-length
2 participants
@MichaReiser @charliermarsh