Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort by key #7963

Merged
merged 13 commits into from
Oct 30, 2023
Merged

Sort by key #7963

merged 13 commits into from
Oct 30, 2023

Commits on Oct 15, 2023

  1. Re-implement module_key function + sort with it 

    Sort straight imports with `sorted_by_cached_key`
    @bluthej
    bluthej committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    8661004 View commit details
    Browse the repository at this point in the history

  2. Re-implement member_key function + use it

    @bluthej
    bluthej committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    4050471 View commit details
    Browse the repository at this point in the history

  3. Rename prefix related things to member type 

    I think it describes what it is more accurately and it's more consistent
with the isort terminology
    @bluthej
    bluthej committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    e6ef94c View commit details
    Browse the repository at this point in the history

  4. Unify module key between straight and from imports

    @bluthej
    bluthej committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    8b82da0 View commit details
    Browse the repository at this point in the history

  5. Replace last call to cmp_either_import 

    Remove all the `cmp_*` functions
    @bluthej
    bluthej committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    a902a90 View commit details
    Browse the repository at this point in the history

  6. Make meaning of two bools clearer

    @bluthej
    bluthej committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    452d7ef View commit details
    Browse the repository at this point in the history

  7. Remove useless Display impl

    @bluthej
    bluthej committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    5a4b9dd View commit details
    Browse the repository at this point in the history

  8. Add NatOrdStr to remove some allocations

    @bluthej
    bluthej committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    087bd57 View commit details
    Browse the repository at this point in the history

  9. Remove remaining unnecessary allocations

    @bluthej
    bluthej committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    e01bead View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. Use Cow to avoid unnecessary allocations 

    If the module name is already lowercase we don't have to call
`to_lowercase`, which avoids some allocations (probably a lot since
most modules are lowercase)
    @bluthej
    bluthej committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    56b462f View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. Merge branch 'main' into sort-by-key

    @charliermarsh
    charliermarsh committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    97914c4 View commit details
    Browse the repository at this point in the history

  2. Add docstring

    @charliermarsh
    charliermarsh committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    8163c04 View commit details
    Browse the repository at this point in the history

  3. Remove i64

    @charliermarsh
    charliermarsh committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    c2a15e3 View commit details
    Browse the repository at this point in the history