[flake8-pyi] Implement redundant-none-literal (PYI061)
#14316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| PYI061 | 14 | 14 | 0 | 0 | 0 |
|
Hi @sbrugman Thanks for another PR. It would help me review your PRs and avoid unnecessary work if you could fill out the Test plan. E.g. did you review the ecosystem changes already? If so, then I don't have to do so :) |
|
Is there some previous issue where we discussed this rule? I'm asking because the rule itself would be a better fit for |
|
@MichaReiser I've updated the test plan above, will do so for the other issues as well. You're right that these rules fit better in another category, but since there is no upstream rule I've placed them here. I'm ok moving the rules if preferred. |
MichaReiser
added
rule
|
It looks like this could actually be in flake8-pyi: |
sbrugman
changed the title
ruff] Implement redundant-none-literal (RUF037)flake8-pyi] Implement redundant-none-literal (PYI061)
sbrugman
force-pushed
the
redundant-none-literal
branch
from
9f4cad0
to
581f0da
Compare
MichaReiser
approved these changes
Nov 14, 2024
Comment on lines
+96
to
+98
| if let Some(ref fix) = fix { | ||
| diagnostic.set_fix(fix.clone()); | ||
| } |
There was a problem hiding this comment.
I'm surprised that setting the same fix works 😆
AlexWaygood
reviewed
Nov 14, 2024
crates/ruff_linter/src/rules/flake8_pyi/rules/redundant_none_literal.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/flake8_pyi/rules/redundant_none_literal.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/resources/test/fixtures/flake8_pyi/PYI061.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Alex Waygood <[email protected]>
AlexWaygood
approved these changes
Nov 14, 2024
crates/ruff_linter/resources/test/fixtures/flake8_pyi/PYI061.pyi
Outdated
Show resolved
Hide resolved
crates/ruff_linter/resources/test/fixtures/flake8_pyi/PYI061.pyi
Outdated
Show resolved
Hide resolved
dylwil3
pushed a commit
to dylwil3/ruff
that referenced
this pull request
Nov 17, 2024
…sh#14316) ## Summary `Literal[None]` can be simplified into `None` in type annotations. Surprising to see that this is not that rare: - https://github.com/langchain-ai/langchain/blob/master/libs/langchain/langchain/chat_models/base.py#L54 - https://github.com/sqlalchemy/sqlalchemy/blob/main/lib/sqlalchemy/sql/annotation.py#L69 - https://github.com/jax-ml/jax/blob/main/jax/numpy/__init__.pyi#L961 - https://github.com/huggingface/huggingface_hub/blob/main/src/huggingface_hub/inference/_common.py#L179 ## Test Plan `cargo test` Reviewed all ecosystem results, and they are true positives. --------- Co-authored-by: Alex Waygood <[email protected]> Co-authored-by: Charlie Marsh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Literal[None]can be simplified intoNonein type annotations.Surprising to see that this is not that rare:
Test Plan
cargo testReviewed all ecosystem results, and they are true positives.