Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flake8-simplify] Include caveats of enabling if-else-block-instead-of-if-exp (SIM108) #14019

Merged
merged 4 commits into from
Oct 31, 2024
Merged

[flake8-simplify] Include caveats of enabling if-else-block-instead-of-if-exp (SIM108) #14019

merged 4 commits into from
Oct 31, 2024

Conversation

sbrugman
Copy link
Contributor

Summary

This aims to acknowledge the existing issues (#14017, #5528) and help users decide whether to enable this rule.

Test Plan

@sbrugman sbrugman changed the title [flake8-simplify'] Include caveats of enabling if-else-block-instead-of-if-exp` (SIM108) [flake8-simplify] Include caveats of enabling if-else-block-instead-of-if-exp (SIM108) Oct 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 31, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@AlexWaygood AlexWaygood added the documentation Improvements or additions to documentation label Oct 31, 2024
@MichaReiser
Copy link
Member

Awesome, thank you

AlexWaygood
AlexWaygood approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@AlexWaygood AlexWaygood enabled auto-merge (squash) October 31, 2024 17:19
@AlexWaygood AlexWaygood merged commit 9a6b08b into astral-sh:main Oct 31, 2024
20 checks passed
@sbrugman sbrugman deleted the docs-if-else-block-instead-of-if-exp-sim108 branch October 31, 2024 18:07
@BrewTestBot BrewTestBot mentioned this pull request Nov 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbrugman @MichaReiser @AlexWaygood