Mark `FURB118` fix as unsafe #13613

zanieb · 2024-10-03T17:25:39Z

Closes #13421

github-actions · 2024-10-03T17:39:32Z

`ruff-ecosystem` results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+0 -0 violations, +0 -232 fixes in 4 projects; 50 projects unchanged)

apache/airflow (+0 -0 violations, +0 -88 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ airflow/api_connexion/endpoints/task_instance_endpoint.py:778:25: FURB118 Use `operator.itemgetter("name")` instead of defining a lambda
- airflow/api_connexion/endpoints/task_instance_endpoint.py:778:25: FURB118 [*] Use `operator.itemgetter("name")` instead of defining a lambda
+ airflow/providers/amazon/aws/hooks/redshift_cluster.py:138:28: FURB118 Use `operator.itemgetter("SnapshotCreateTime")` instead of defining a lambda
- airflow/providers/amazon/aws/hooks/redshift_cluster.py:138:28: FURB118 [*] Use `operator.itemgetter("SnapshotCreateTime")` instead of defining a lambda
+ airflow/providers/databricks/operators/databricks.py:1126:46: FURB118 Use `operator.itemgetter("start_time")` instead of defining a lambda
- airflow/providers/databricks/operators/databricks.py:1126:46: FURB118 [*] Use `operator.itemgetter("start_time")` instead of defining a lambda
+ airflow/providers/weaviate/hooks/weaviate.py:638:31: FURB118 Use `operator.itemgetter(uuid_column)` instead of defining a lambda
- airflow/providers/weaviate/hooks/weaviate.py:638:31: FURB118 [*] Use `operator.itemgetter(uuid_column)` instead of defining a lambda
+ airflow/providers/weaviate/hooks/weaviate.py:682:23: FURB118 Use `operator.itemgetter(uuid_column)` instead of defining a lambda
- airflow/providers/weaviate/hooks/weaviate.py:682:23: FURB118 [*] Use `operator.itemgetter(uuid_column)` instead of defining a lambda
+ airflow/providers_manager.py:1347:59: FURB118 Use `operator.itemgetter(0)` instead of defining a lambda
- airflow/providers_manager.py:1347:59: FURB118 [*] Use `operator.itemgetter(0)` instead of defining a lambda
+ airflow/providers_manager.py:1351:59: FURB118 Use `operator.itemgetter(0)` instead of defining a lambda
- airflow/providers_manager.py:1351:59: FURB118 [*] Use `operator.itemgetter(0)` instead of defining a lambda
+ dev/stats/get_important_pr_candidates.py:387:69: FURB118 Use `operator.itemgetter(1)` instead of defining a lambda
- dev/stats/get_important_pr_candidates.py:387:69: FURB118 [*] Use `operator.itemgetter(1)` instead of defining a lambda
+ docs/conf.py:573:26: FURB118 Use `operator.itemgetter("name")` instead of defining a lambda
- docs/conf.py:573:26: FURB118 [*] Use `operator.itemgetter("name")` instead of defining a lambda
... 70 additional changes omitted for project

apache/superset (+0 -0 violations, +0 -32 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ scripts/cancel_github_workflows.py:205:29: FURB118 Use `operator.itemgetter("created_at")` instead of defining a lambda
- scripts/cancel_github_workflows.py:205:29: FURB118 [*] Use `operator.itemgetter("created_at")` instead of defining a lambda
+ superset/charts/post_processing.py:234:14: FURB118 Use `operator.itemgetter(slice(1))` instead of defining a lambda
- superset/charts/post_processing.py:234:14: FURB118 [*] Use `operator.itemgetter(slice(1))` instead of defining a lambda
+ superset/charts/post_processing.py:235:13: FURB118 Use `operator.itemgetter(slice(-1, None))` instead of defining a lambda
- superset/charts/post_processing.py:235:13: FURB118 [*] Use `operator.itemgetter(slice(-1, None))` instead of defining a lambda
+ superset/commands/database/tables.py:125:21: FURB118 Use `operator.itemgetter("value")` instead of defining a lambda
- superset/commands/database/tables.py:125:21: FURB118 [*] Use `operator.itemgetter("value")` instead of defining a lambda
+ superset/databases/api.py:2101:21: FURB118 Use `operator.itemgetter("name")` instead of defining a lambda
- superset/databases/api.py:2101:21: FURB118 [*] Use `operator.itemgetter("name")` instead of defining a lambda
... 22 additional changes omitted for project

bokeh/bokeh (+0 -0 violations, +0 -26 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ examples/topics/categorical/les_mis.py:18:61: FURB118 Use `operator.itemgetter('group')` instead of defining a lambda
- examples/topics/categorical/les_mis.py:18:61: FURB118 [*] Use `operator.itemgetter('group')` instead of defining a lambda
+ src/bokeh/core/query.py:354:9: FURB118 Use `operator.gt` instead of defining a lambda
- src/bokeh/core/query.py:354:9: FURB118 [*] Use `operator.gt` instead of defining a lambda
+ src/bokeh/core/query.py:355:9: FURB118 Use `operator.lt` instead of defining a lambda
- src/bokeh/core/query.py:355:9: FURB118 [*] Use `operator.lt` instead of defining a lambda
+ src/bokeh/core/query.py:356:9: FURB118 Use `operator.eq` instead of defining a lambda
- src/bokeh/core/query.py:356:9: FURB118 [*] Use `operator.eq` instead of defining a lambda
+ src/bokeh/core/query.py:357:9: FURB118 Use `operator.ge` instead of defining a lambda
- src/bokeh/core/query.py:357:9: FURB118 [*] Use `operator.ge` instead of defining a lambda
... 16 additional changes omitted for project

zulip/zulip (+0 -0 violations, +0 -86 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ analytics/views/stats.py:570:82: FURB118 Use `operator.itemgetter(1)` instead of defining a lambda
- analytics/views/stats.py:570:82: FURB118 [*] Use `operator.itemgetter(1)` instead of defining a lambda
+ corporate/views/support.py:608:39: FURB118 Use `operator.itemgetter("display_order")` instead of defining a lambda
- corporate/views/support.py:608:39: FURB118 [*] Use `operator.itemgetter("display_order")` instead of defining a lambda
+ zerver/actions/default_streams.py:195:62: FURB118 Use `operator.itemgetter("name")` instead of defining a lambda
- zerver/actions/default_streams.py:195:62: FURB118 [*] Use `operator.itemgetter("name")` instead of defining a lambda
+ zerver/actions/message_send.py:425:9: FURB118 Use `operator.itemgetter("enable_online_push_notifications")` instead of defining a lambda
- zerver/actions/message_send.py:425:9: FURB118 [*] Use `operator.itemgetter("enable_online_push_notifications")` instead of defining a lambda
+ zerver/actions/message_send.py:444:9: FURB118 Use `operator.itemgetter("long_term_idle")` instead of defining a lambda
- zerver/actions/message_send.py:444:9: FURB118 [*] Use `operator.itemgetter("long_term_idle")` instead of defining a lambda
+ zerver/context_processors.py:295:68: FURB118 Use `operator.itemgetter("display_order")` instead of defining a lambda
- zerver/context_processors.py:295:68: FURB118 [*] Use `operator.itemgetter("display_order")` instead of defining a lambda
+ zerver/lib/default_streams.py:30:37: FURB118 Use `operator.itemgetter("name")` instead of defining a lambda
- zerver/lib/default_streams.py:30:37: FURB118 [*] Use `operator.itemgetter("name")` instead of defining a lambda
+ zerver/lib/display_recipient.py:143:24: FURB118 Use `operator.itemgetter(0)` instead of defining a lambda
- zerver/lib/display_recipient.py:143:24: FURB118 [*] Use `operator.itemgetter(0)` instead of defining a lambda
+ zerver/lib/display_recipient.py:144:16: FURB118 Use `operator.itemgetter(1)` instead of defining a lambda
- zerver/lib/display_recipient.py:144:16: FURB118 [*] Use `operator.itemgetter(1)` instead of defining a lambda
... 68 additional changes omitted for project

Changes by rule (1 rules affected)

code	total	+ violation	- violation	+ fix	- fix
FURB118	232	0	0	0	232

crates/ruff_linter/src/rules/refurb/rules/reimplemented_operator.rs

…or.rs

##### [`v0.6.9](https://github.com/astral-sh/ruff/blob/HEAD/CHANGELOG.md#069) ##### Preview features - Fix codeblock dynamic line length calculation for indented docstring examples ([#13523](astral-sh/ruff#13523)) - \[`refurb`] Mark `FURB118` fix as unsafe ([#13613](astral-sh/ruff#13613)) ##### Rule changes - \[`pydocstyle`] Don't raise `D208` when last line is non-empty ([#13372](astral-sh/ruff#13372)) - \[`pylint`] Preserve trivia (i.e. comments) in `PLR5501` autofix ([#13573](astral-sh/ruff#13573)) ##### Configuration - \[`pyflakes`] Add `allow-unused-imports` setting for `unused-import` rule (`F401`) ([#13601](astral-sh/ruff#13601)) ##### Bug fixes - Support ruff discovery in pip build environments ([#13591](astral-sh/ruff#13591)) - \[`flake8-bugbear`] Avoid short circuiting `B017` for multiple context managers ([#13609](astral-sh/ruff#13609)) - \[`pylint`] Do not offer an invalid fix for `PLR1716` when the comparisons contain parenthesis ([#13527](astral-sh/ruff#13527)) - \[`pyupgrade`] Fix `UP043` to apply to `collections.abc.Generator` and `collections.abc.AsyncGenerator` ([#13611](astral-sh/ruff#13611)) - \[`refurb`] Fix handling of slices in tuples for `FURB118`, e.g., `x[:, 1]` ([#13518](astral-sh/ruff#13518)) ##### Documentation - Update GitHub Action link to `astral-sh/ruff-action` ([#13551](astral-sh/ruff#13551))

##### v0.6.9 (`https://github.com/astral-sh/ruff/blob/HEAD/CHANGELOG.md#069`) ##### Preview features - Fix codeblock dynamic line length calculation for indented docstring examples ([#13523](astral-sh/ruff#13523)) - \[`refurb`] Mark `FURB118` fix as unsafe ([#13613](astral-sh/ruff#13613)) ##### Rule changes - \[`pydocstyle`] Don't raise `D208` when last line is non-empty ([#13372](astral-sh/ruff#13372)) - \[`pylint`] Preserve trivia (i.e. comments) in `PLR5501` autofix ([#13573](astral-sh/ruff#13573)) ##### Configuration - \[`pyflakes`] Add `allow-unused-imports` setting for `unused-import` rule (`F401`) ([#13601](astral-sh/ruff#13601)) ##### Bug fixes - Support ruff discovery in pip build environments ([#13591](astral-sh/ruff#13591)) - \[`flake8-bugbear`] Avoid short circuiting `B017` for multiple context managers ([#13609](astral-sh/ruff#13609)) - \[`pylint`] Do not offer an invalid fix for `PLR1716` when the comparisons contain parenthesis ([#13527](astral-sh/ruff#13527)) - \[`pyupgrade`] Fix `UP043` to apply to `collections.abc.Generator` and `collections.abc.AsyncGenerator` ([#13611](astral-sh/ruff#13611)) - \[`refurb`] Fix handling of slices in tuples for `FURB118`, e.g., `x[:, 1]` ([#13518](astral-sh/ruff#13518)) ##### Documentation - Update GitHub Action link to `astral-sh/ruff-action` ([#13551](astral-sh/ruff#13551))

##### v0.6.9 ##### Preview features - Fix codeblock dynamic line length calculation for indented docstring examples ([#13523](astral-sh/ruff#13523)) - \[`refurb`] Mark `FURB118` fix as unsafe ([#13613](astral-sh/ruff#13613)) ##### Rule changes - \[`pydocstyle`] Don't raise `D208` when last line is non-empty ([#13372](astral-sh/ruff#13372)) - \[`pylint`] Preserve trivia (i.e. comments) in `PLR5501` autofix ([#13573](astral-sh/ruff#13573)) ##### Configuration - \[`pyflakes`] Add `allow-unused-imports` setting for `unused-import` rule (`F401`) ([#13601](astral-sh/ruff#13601)) ##### Bug fixes - Support ruff discovery in pip build environments ([#13591](astral-sh/ruff#13591)) - \[`flake8-bugbear`] Avoid short circuiting `B017` for multiple context managers ([#13609](astral-sh/ruff#13609)) - \[`pylint`] Do not offer an invalid fix for `PLR1716` when the comparisons contain parenthesis ([#13527](astral-sh/ruff#13527)) - \[`pyupgrade`] Fix `UP043` to apply to `collections.abc.Generator` and `collections.abc.AsyncGenerator` ([#13611](astral-sh/ruff#13611)) - \[`refurb`] Fix handling of slices in tuples for `FURB118`, e.g., `x[:, 1]` ([#13518](astral-sh/ruff#13518)) ##### Documentation - Update GitHub Action link to `astral-sh/ruff-action` ([#13551](astral-sh/ruff#13551))

Mark FURB118 fix as unsafe

b88c96a

Closes #13421

zanieb added the fixes Related to suggested fixes for violations label Oct 3, 2024

zanieb added bug Something isn't working preview Related to preview mode features labels Oct 3, 2024

AlexWaygood approved these changes Oct 3, 2024

View reviewed changes

crates/ruff_linter/src/rules/refurb/rules/reimplemented_operator.rs Outdated Show resolved Hide resolved

Update crates/ruff_linter/src/rules/refurb/rules/reimplemented_operat…

525c013

…or.rs

zanieb enabled auto-merge (squash) October 3, 2024 21:35

zanieb merged commit 99e4566 into main Oct 3, 2024
18 checks passed

zanieb deleted the zb/reimpl-op-unsafe branch October 3, 2024 21:39

BrewTestBot mentioned this pull request Oct 4, 2024

ruff 0.6.9 Homebrew/homebrew-core#192823

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mark `FURB118` fix as unsafe #13613

Mark `FURB118` fix as unsafe #13613

zanieb commented Oct 3, 2024

github-actions bot commented Oct 3, 2024 •

edited

Loading

Mark FURB118 fix as unsafe #13613

Mark FURB118 fix as unsafe #13613

Conversation

zanieb commented Oct 3, 2024

github-actions bot commented Oct 3, 2024 • edited Loading

ruff-ecosystem results

Linter (stable)

Linter (preview)

Mark `FURB118` fix as unsafe #13613

Mark `FURB118` fix as unsafe #13613

github-actions bot commented Oct 3, 2024 •

edited

Loading

`ruff-ecosystem` results