Stabilize ASYNC100, ASYNC109, ASYNC110, ASYNC115 and ASYNC116 behavior changes
#12844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
added
rule
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| ICN001 | 5 | 5 | 0 | 0 | 0 |
Linter (preview)
ℹ️ ecosystem check detected linter changes. (+23 -18 violations, +0 -0 fixes in 15 projects; 39 projects unchanged)
DisnakeDev/disnake (+1 -1 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
+ disnake/ext/commands/flag_converter.py:314:28: C420 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead - disnake/ext/commands/flag_converter.py:314:28: RUF025 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead
RasaHQ/rasa (+0 -3 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
- rasa/core/evaluation/marker_stats.py:114:51: RUF025 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead - rasa/core/featurizers/single_state_featurizer.py:119:20: RUF025 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead - tests/core/featurizers/test_precomputation.py:110:17: RUF025 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead
PlasmaPy/PlasmaPy (+1 -0 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
+ src/plasmapy/particles/ionization_state_collection.py:693:40: C420 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead
apache/airflow (+3 -2 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL
+ helm_tests/airflow_aux/test_annotations.py:409:63: C420 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead - helm_tests/airflow_aux/test_annotations.py:409:63: RUF025 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead + tests/test_utils/get_all_tests.py:26:23: ICN001 `xml.etree.ElementTree` should be imported as `ET` + tests/ti_deps/deps/test_mapped_task_upstream_dep.py:459:36: C420 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead - tests/ti_deps/deps/test_mapped_task_upstream_dep.py:459:36: RUF025 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead
apache/superset (+3 -3 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL
+ superset/reports/notifications/email.py:58:28: C420 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead - superset/reports/notifications/email.py:58:28: RUF025 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead + superset/reports/notifications/slack_mixin.py:107:43: C420 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead - superset/reports/notifications/slack_mixin.py:107:43: RUF025 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead + superset/reports/notifications/slack_mixin.py:97:39: C420 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead - superset/reports/notifications/slack_mixin.py:97:39: RUF025 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead
bokeh/bokeh (+4 -2 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL
+ src/bokeh/command/subcommands/file_output.py:145:17: C420 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead - src/bokeh/command/subcommands/file_output.py:145:17: RUF025 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead + src/bokeh/command/subcommands/serve.py:831:17: C420 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead - src/bokeh/command/subcommands/serve.py:831:17: RUF025 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead + src/bokeh/sampledata/us_counties.py:45:33: ICN001 `xml.etree.ElementTree` should be imported as `ET` + src/bokeh/sampledata/us_states.py:44:33: ICN001 `xml.etree.ElementTree` should be imported as `ET`
docker/docker-py (+1 -0 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
+ docker/types/containers.py:725:22: C420 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead
ibis-project/ibis (+1 -1 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
+ ibis/common/egraph.py:776:17: C420 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead - ibis/common/egraph.py:776:17: RUF025 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead
jrnl-org/jrnl (+2 -0 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
+ tests/lib/given_steps.py:12:23: ICN001 `xml.etree.ElementTree` should be imported as `ET` + tests/lib/then_steps.py:7:23: ICN001 `xml.etree.ElementTree` should be imported as `ET`
mlflow/mlflow (+1 -0 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
+ tests/metrics/genai/test_genai_metrics.py:554:37: C420 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead
pypa/build (+1 -1 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
+ src/build/__main__.py:40:14: C420 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead - src/build/__main__.py:40:14: RUF025 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead
pypa/pip (+2 -0 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
+ src/pip/_internal/locations/_sysconfig.py:164:21: C420 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead + src/pip/_internal/locations/_sysconfig.py:166:21: C420 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead
scikit-build/scikit-build (+2 -2 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
+ skbuild/setuptools_wrap.py:516:22: C420 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead - skbuild/setuptools_wrap.py:516:22: RUF025 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead + skbuild/setuptools_wrap.py:519:19: C420 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead - skbuild/setuptools_wrap.py:519:19: RUF025 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead
pytest-dev/pytest (+0 -3 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
- src/_pytest/logging.py:128:24: RUF025 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead - src/_pytest/reports.py:345:20: RUF025 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead - testing/conftest.py:191:21: RUF025 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead
mesonbuild/meson-python (+1 -0 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
+ mesonpy/__init__.py:570:24: C420 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead
Changes by rule (3 rules affected)
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| C420 | 18 | 18 | 0 | 0 | 0 |
| RUF025 | 18 | 0 | 18 | 0 | 0 |
| ICN001 | 5 | 5 | 0 | 0 | 0 |
AlexWaygood
approved these changes
Aug 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #12268
Test Plan
I reviewed the updated snapshots