Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat type(Protocol) et al as metaclass base #12770

Merged
merged 5 commits into from
Aug 9, 2024
Merged

Treat type(Protocol) et al as metaclass base #12770

merged 5 commits into from
Aug 9, 2024

Conversation

charliermarsh
Copy link
Member

Summary

Closes #12736.

charliermarsh
charliermarsh commented Aug 9, 2024
View reviewed changes
crates/ruff_python_semantic/src/analyze/class.rs
| ["abc", "ABCMeta"]
| ["enum", "EnumMeta" | "EnumType"]
)
}),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only logic change.

@charliermarsh charliermarsh added the bug Something isn't working label Aug 9, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Aug 9, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #12770 will not alter performance

Comparing charlie/meta (f98f274) with main (37b9bac)

Summary

✅ 32 untouched benchmarks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 9, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

AlexWaygood
AlexWaygood approved these changes Aug 9, 2024
View reviewed changes
crates/ruff_python_semantic/src/analyze/class.rs Outdated Show resolved Hide resolved
crates/ruff_python_semantic/src/analyze/class.rs Outdated Show resolved Hide resolved
@charliermarsh
Copy link
Member Author

Thanks Alex!

@charliermarsh charliermarsh enabled auto-merge (squash) August 9, 2024 20:05
@charliermarsh charliermarsh merged commit 69e1c56 into main Aug 9, 2024
16 checks passed
@charliermarsh charliermarsh deleted the charlie/meta branch August 9, 2024 20:10
@BrewTestBot BrewTestBot mentioned this pull request Aug 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaReiser MichaReiser MichaReiser left review comments

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

N805 False positive for class Meta(type(base))
3 participants
@charliermarsh @MichaReiser @AlexWaygood