Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort edits prior to deduplicating in quotation fix #11452

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

charliermarsh
Copy link
Member

Summary

We already have handling for "references that get quoted within our quoted references", but we were assuming a specific ordering in the way edits were generated.

Closes #11449.

@charliermarsh charliermarsh added the bug Something isn't working label May 16, 2024
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@charliermarsh charliermarsh merged commit 43e8147 into main May 16, 2024
18 of 19 checks passed
@charliermarsh charliermarsh deleted the charlie/pref branch May 16, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic when quoting annotations
1 participant