Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Python 3.13 to list of allowed Python versions #11411

Merged
merged 1 commit into from
May 13, 2024
Merged

Add Python 3.13 to list of allowed Python versions #11411

merged 1 commit into from
May 13, 2024

Conversation

charliermarsh
Copy link
Member

Summary

I believe we're already "Python 3.13-ready"? The main Ruff-impacting change I see in https://docs.python.org/3.13/whatsnew/3.13.html is PEP 696 which Jelle added in #11120.

Base automatically changed from charlie/std to main May 13, 2024 16:27
@charliermarsh charliermarsh enabled auto-merge (squash) May 13, 2024 16:29
@charliermarsh charliermarsh merged commit 6ed2482 into main May 13, 2024
38 checks passed
@charliermarsh charliermarsh deleted the charlie/py313 branch May 13, 2024 16:35
@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@AlexWaygood
Copy link
Member

I guess one other thing we could do is update UP035 to emit a diagnostic if --target-version=py313 has been selected and a user imports typing.TypeIs, warnings.deprecated, typing.ReadOnly, typing.NoDefault typing.get_protocol_members or typing.is_protocol from typing_extensions rather than typing

@charliermarsh
Copy link
Member Author

Makes sense, mind filing an issue (or PRing it)? :)

@AlexWaygood AlexWaygood mentioned this pull request May 13, 2024
Closed
@AlexWaygood
Copy link
Member

Makes sense, mind filing an issue (or PRing it)? :)

#11413

@BrewTestBot BrewTestBot mentioned this pull request May 23, 2024
Merged
starsep added a commit to starsep/ruff that referenced this pull request Jun 13, 2024
@starsep
Update Python compatibility to 3.13
5b94ca5 
Reference: astral-sh#11411
@starsep starsep mentioned this pull request Jun 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

@zanieb zanieb zanieb approved these changes

@MichaReiser MichaReiser Awaiting requested review from MichaReiser MichaReiser is a code owner

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@charliermarsh @AlexWaygood @zanieb @dhruvmanila