Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some hardcoded modules from generate_known_standard_library.py #11409

Merged
merged 1 commit into from
May 13, 2024
Merged

Remove some hardcoded modules from generate_known_standard_library.py #11409

merged 1 commit into from
May 13, 2024

Conversation

charliermarsh
Copy link
Member

See feedback in: #11374

@charliermarsh charliermarsh added the internal An internal refactor or improvement label May 13, 2024
@charliermarsh charliermarsh mentioned this pull request May 13, 2024
Merged
thatch
thatch reviewed May 13, 2024
View reviewed changes
Copy link
Contributor

@thatch thatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@charliermarsh charliermarsh merged commit dc5c44c into main May 13, 2024
19 checks passed
@charliermarsh charliermarsh deleted the charlie/std branch May 13, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatch thatch thatch left review comments

@zanieb zanieb zanieb approved these changes

Assignees
No one assigned
Labels
internal An internal refactor or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charliermarsh @thatch @zanieb