Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format Constant::Ellipsis #4987

Closed
evanrittenhouse opened this issue Jun 9, 2023 · 6 comments
Closed

Format Constant::Ellipsis #4987

evanrittenhouse opened this issue Jun 9, 2023 · 6 comments
Assignees
@evanrittenhouse
Labels
formatter Related to the formatter

Comments

@evanrittenhouse
Copy link
Contributor

From #4798
@evanrittenhouse
Copy link
Contributor Author

@MichaReiser can you please assign this to me? Interested in moving into the formatter

@MichaReiser
Copy link
Member

MichaReiser commented Jun 9, 2023 •
edited
Loading

Nice!
I'll be off next week, but you can reach out to @konstin with questions.

@charliermarsh charliermarsh added the formatter Related to the formatter label Jun 9, 2023
@evanrittenhouse
Copy link
Contributor Author

@konstin Hey, just going through the code for this. I'm curious why this line doesn't already format Constant::Ellipsis? Happy to implement the issue, but not sure what else has to be done.

@charliermarsh
Copy link
Member

From my perspective, it does look complete, but I’ll let Konsti chime in.

@konstin
Copy link
Member

konstin commented Jun 12, 2023

Sorry, that was already implemented, i updated #4798 now

@evanrittenhouse
Copy link
Contributor Author

All good, we can probably close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evanrittenhouse evanrittenhouse

Labels
formatter Related to the formatter
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@MichaReiser @charliermarsh @konstin @evanrittenhouse