S113: Not identified in sessions

[kiblik]

S113 can idenify if request is missing timeout and it runs "natively". However, it does not identify run from existing sessions.

code

import requests

requests.get("https://example.com")  # violation identified - Good
requests.get("https://example.com", timeout=5)  # correct implementation

s = requests.session()
s.get("https://example.com")  # violation NOT identified - Bad
s.get("https://example.com", timeout=5)  # correct implementation

config

[lint]
select = ["S113"]

version

$ ruff --version
ruff 0.7.2

[dhruvmanila]

Thanks for the issue. I don't think this is currently possible as Ruff needs to know the type of symbol s here. We're currently working on it (Red Knot project) but it'll take some time before it can be utilized.