Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Panic] broken pipe leads to panic #13483

Closed
mitsuhiko opened this issue Sep 23, 2024 · 2 comments · Fixed by #13485
Closed

[Panic] broken pipe leads to panic #13483

mitsuhiko opened this issue Sep 23, 2024 · 2 comments · Fixed by #13485
Assignees
@charliermarsh
Labels
bug Something isn't working

Comments

@mitsuhiko
Copy link 

ruff analyze graph --preview| bat -l json --color=always

Hit quit, be presented with a broken pipe:

error: Ruff crashed. If you could open an issue at:

    https://github.com/astral-sh/ruff/issues/new?title=%5BPanic%5D

...quoting the executed command, along with the relevant file contents and `pyproject.toml` settings, we'd be very appreciative!

thread 'main' panicked at library/std/src/io/stdio.rs:1118:9:
failed printing to stdout: Broken pipe (os error 32)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Classic rust command line tool behavior :)
@charliermarsh
Copy link
Member

Lol. A duplicate of #13442.

@charliermarsh charliermarsh self-assigned this Sep 23, 2024
@charliermarsh charliermarsh added the bug Something isn't working label Sep 23, 2024
@charliermarsh
Copy link
Member

I'll fix it now.

This was referenced Sep 23, 2024
Merged
Merged
charliermarsh added a commit that referenced this issue Sep 23, 2024
@charliermarsh
Avoid panic when analyze graph hits broken pipe (#13484)
90dc743 
## Summary

I think we should also make the change that @BurntSushi recommended in
the linked issue, but this gets rid of the panic.

See: #13483

See: #13442

## Test Plan

```
warning: `ruff analyze graph` is experimental and may change without warning
{
  "/Users/crmarsh/workspace/django/django/__init__.py": [
    "/Users/crmarsh/workspace/django/django/apps/__init__.py",
    "/Users/crmarsh/workspace/django/django/conf/__init__.py",
    "/Users/crmarsh/workspace/django/django/urls/__init__.py",
    "/Users/crmarsh/workspace/django/django/utils/log.py",
    "/Users/crmarsh/workspace/django/django/utils/version.py"
  ],
  "/Users/crmarsh/workspace/django/django/__main__.py": [
    "/Users/crmarsh/workspace/django/django/core/management/__init__.py"
ruff failed
  Cause: Broken pipe (os error 32)
```
charliermarsh added a commit that referenced this issue Sep 23, 2024
@charliermarsh
Exit gracefully on broken pipe errors (#13485)
96e7f3f 
## Summary

Closes #13483.

Closes #13442.

## Test Plan

```
❯ cargo run analyze graph ../django | head -n 10
   Compiling ruff v0.6.7 (/Users/crmarsh/workspace/ruff/crates/ruff)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.63s
     Running `target/debug/ruff analyze graph ../django`
warning: `ruff analyze graph` is experimental and may change without warning
{
  "/Users/crmarsh/workspace/django/django/__init__.py": [
    "/Users/crmarsh/workspace/django/django/apps/__init__.py",
    "/Users/crmarsh/workspace/django/django/conf/__init__.py",
    "/Users/crmarsh/workspace/django/django/urls/__init__.py",
    "/Users/crmarsh/workspace/django/django/utils/log.py",
    "/Users/crmarsh/workspace/django/django/utils/version.py"
  ],
  "/Users/crmarsh/workspace/django/django/__main__.py": [
    "/Users/crmarsh/workspace/django/django/core/management/__init__.py"
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charliermarsh charliermarsh

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exit gracefully on broken pipe errors astral-sh/ruff
2 participants
@mitsuhiko @charliermarsh