Feature/user expiry #581
Merged
Feature/user expiry #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebeccaskinner
suggested changes
Jan 9, 2017
| @@ -72,6 +73,12 @@ type Preparer struct { | |||
| // HomeDir must also be indicated if MoveDir is set to true. | |||
| MoveDir bool `hcl:"move_dir"` | |||
|
|
|||
| // Expiry is the date on which the user account will be disabled. The date is | |||
| // specified in the format YYYY-MM-DD. If not specified, the default expiry | |||
| // date specified by the EXPIRE variable in /ect/default/useradd, or an empty | |||
There was a problem hiding this comment.
Typo. Should be /etc/default/useradd
| // specified in the format YYYY-MM-DD. If not specified, the default expiry | ||
| // date specified by the EXPIRE variable in /ect/default/useradd, or an empty | ||
| // string (no expiry) will be used by default. | ||
| Expiry time.Time `hcl:"expiry"` |
There was a problem hiding this comment.
Should this be *time.Time? Otherwise any other changes to a user will have the side effect of setting an expiry since we'll always be setting it.
There was a problem hiding this comment.
I only set the expiry if it is specified in the hcl. There are checks in user.go (DiffAdd and DiffMod) for this.
rebeccaskinner
approved these changes
Jan 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to specify a user expiry when adding or modifying a user.