Feature/apt package #461
Merged
Feature/apt package #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
stevendborrelli
commented
Nov 1, 2016
•
stevendborrelli
commented
- adds ability to install/remove debian packages
- refactors some of the code in the package resource to be shared
stevendborrelli
force-pushed
the
feature/apt-package
branch
from
6ebfdf2
to
dba2293
Compare
# Conflicts: # resource/package/package.go # resource/package/rpm/preparer.go
|
Haven't figured out exactly why yet but I am getting the following error when trying to apply https://github.com/asteris-llc/converge/blob/1a41999d0730a51fb8982c3c51db5b07a4ac99de/samples/apt.hcl: (vagrant machine running the |
|
ignore the above (not using sudo, duh) |
ryane
reviewed
Nov 7, 2016
| apt Package manages system packages with `apt` and `dpkg`. It assumes that | ||
| both `apt` and `dpkg` are installed on the system, and that the user has | ||
| permissions to install, remove, and query packages. | ||
|
|
There was a problem hiding this comment.
should we add a note about using group to ensure that multiple apt package installations do not run in parallel? (at least until we add an implicit group into the apt resource)
|
|
||
| // Prepare a new package | ||
| func (p *Preparer) Prepare(ctx context.Context, render resource.Renderer) (resource.Task, error) { | ||
| if p.State == "" { |
There was a problem hiding this comment.
might want to validate that Name != ""
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.