Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Fonts Module Level 4: Support font-style: oblique with an angle #7

Open
papandreou opened this issue Jul 23, 2020 · 0 comments
Open

Comments

@papandreou
Copy link
Member

papandreou commented Jul 23, 2020

Working draft: https://www.w3.org/TR/css-fonts-4/#font-style-prop

At the moment it's only supported by Firefox, so it's not really urgent.

Also plays into the font matching algorithm: https://www.w3.org/TR/css-fonts-4/#font-matching-algorithm

Presently font-snapper only works properly with font-style: oblique without an angle. There's a hack in place to avoid crashing:

// Hack to treat oblique <angle> as oblique until we add proper support
function removeObliqueAngle(fontStyle) {
if (/^oblique\b/.test(fontStyle)) {
return 'oblique';
} else {
return fontStyle;
}
}

Once implemented, add to the fuzz tests by switching to headless Firefox and removing:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant