From 38c0817e5ec2a27bef3303193434536924fa9ace Mon Sep 17 00:00:00 2001 From: Abel Soares Siqueira Date: Thu, 17 Aug 2023 14:57:00 +0200 Subject: [PATCH 1/3] Improve documentation based on Jelle's feedback --- 40-kubernetes.md | 8 ++++---- 42-kubernetes-cloud-provider.md | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/40-kubernetes.md b/40-kubernetes.md index 2980d72..4eca1f3 100644 --- a/40-kubernetes.md +++ b/40-kubernetes.md @@ -115,7 +115,7 @@ echo -n 'WHATEVER' | base64 Copy that value and paste in the appropriate field of the file. -Finally, run the secret: +Finally, apply the secret configuration: ```bash kubectl apply -f s3-secret.yml @@ -133,7 +133,7 @@ To change that, edit [tasker.sh](code/tasker.sh). The [tasker.sh](code/tasker.sh) defines everything that will be executed by the tasker, and indirectly by the workers. The [tasker.Dockerfile](code/tasker.Dockerfile) will create the image that will be executed in the tasker pod. -You can modify these as you see fit. +You can modify these files as you see fit. The default commands used inside the tasker script and Dockerfile assume that you are: @@ -223,7 +223,7 @@ Change the `image` to reflect the path to the image that you pushed. > **Warning** > -> Did you change the image? +> Don't forget to change the image in the worker.yml file. You can select the number of `replicas` to change the number of workers. Pay attention to the resource limits, and change as you see fit. @@ -261,7 +261,7 @@ Change the `image`, and optionally add a `ttlSecondsAfterFinished` to auto delet > **Warning** > -> Did you change the image? +> Don't forget to change the image in the tasker.yml file. Run diff --git a/42-kubernetes-cloud-provider.md b/42-kubernetes-cloud-provider.md index 4bf474f..0d5d057 100644 --- a/42-kubernetes-cloud-provider.md +++ b/42-kubernetes-cloud-provider.md @@ -49,7 +49,7 @@ nfs-service ClusterIP NFS_SERVICE_IP 2049/TCP,20048/TCP,1 ``` Copy the `NFS_SERVICE_IP`. -Then, uncomment the [worker.yml](k8-config/worker.yml) and [tasker.yml](k8-config/tasker.yml) relevant part at the `volumes` section in the end. +Then, uncomment the first 3 lines of the `volumes` sections of files [worker.yml](k8-config/worker.yml) and [tasker.yml](k8-config/tasker.yml) (end of the file). For this case, it should look like ```yml From 72eb35e4c5c47e0b7ff817cf911684a3ab8f1d51 Mon Sep 17 00:00:00 2001 From: Abel Soares Siqueira Date: Thu, 17 Aug 2023 17:27:21 +0200 Subject: [PATCH 2/3] Update 40-kubernetes.md Co-authored-by: Rens van de schoot <36502709+Rensvandeschoot@users.noreply.github.com> --- 40-kubernetes.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/40-kubernetes.md b/40-kubernetes.md index 4eca1f3..9df5158 100644 --- a/40-kubernetes.md +++ b/40-kubernetes.md @@ -223,7 +223,7 @@ Change the `image` to reflect the path to the image that you pushed. > **Warning** > -> Don't forget to change the image in the worker.yml file. +> Make sure to change the image in the worker.yml file. You can select the number of `replicas` to change the number of workers. Pay attention to the resource limits, and change as you see fit. From ae03dc55ef2afadb449861380f5cfef75725e899 Mon Sep 17 00:00:00 2001 From: Abel Soares Siqueira Date: Thu, 17 Aug 2023 17:27:27 +0200 Subject: [PATCH 3/3] Update 40-kubernetes.md Co-authored-by: Rens van de schoot <36502709+Rensvandeschoot@users.noreply.github.com> --- 40-kubernetes.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/40-kubernetes.md b/40-kubernetes.md index 9df5158..18af574 100644 --- a/40-kubernetes.md +++ b/40-kubernetes.md @@ -261,7 +261,7 @@ Change the `image`, and optionally add a `ttlSecondsAfterFinished` to auto delet > **Warning** > -> Don't forget to change the image in the tasker.yml file. +> Make sure to change the image in the tasker.yml file. Run