Skip to content
This repository has been archived by the owner on Dec 18, 2017. It is now read-only.

Rename k-crossgen tool #1572

Closed
ChengTian opened this issue Apr 2, 2015 · 11 comments
Closed

Rename k-crossgen tool #1572

ChengTian opened this issue Apr 2, 2015 · 11 comments
Assignees
Milestone

Comments

@ChengTian
Copy link
Contributor

Reported by @moozzyk

This is the last k-*.cmd we have. It's mainly an internally used tool, so the renaming is not urgent.

@muratg @davidfowl Do we want to rename it to dnx-crossgen? Or you have some better names for it

@ChengTian ChengTian added the bug label Apr 2, 2015
@davidfowl
Copy link
Member

merge it into dnu or make it another global command /cc @loudej

@ChengTian
Copy link
Contributor Author

I guess merging it into dnu is better.

dnvm is using k-crossgen and assumes k-corssgen comes with dnx. Making k-crossgen a global command means dnvm will need to install this global command first. It's very different from the current approach.

@davidfowl
Copy link
Member

Ah hah! Yes lets merge it in

@muratg muratg added this to the 1.0.0-beta5 milestone Apr 2, 2015
@ChengTian
Copy link
Contributor Author

So we all agree on the new name dnx-crossgen?

@muratg
Copy link
Contributor

muratg commented Apr 30, 2015

dnx-crossgen sounds fine to me. Unless @davidfowl has any objections, let's go with that name.

@analogrelay
Copy link
Contributor

dnu optimize ? Eventually, it could even take parameters such as allowing me to "optimize" specific packages/apps/runtimes/whatever.

I, as a user, have no idea what a crossgen is... but regardless, people don't generally run this command manually so I'm not very worried either way.

@ChengTian
Copy link
Contributor Author

I guess optimize is a too general term and users may imagine they can do something like

dnu optimize MyApp

to make their apps run faster...

If we don't expect people to use this in most cases, crossgen can be a better choice, which means "keep away if you don't know what it is"

@troydai
Copy link
Contributor

troydai commented May 1, 2015

In CLR we use Ngen.exe as well. I think crossgen is a more accurate name.

@ChengTian
Copy link
Contributor Author

Moving forward with dnx-crossgen if there is no objection

@muratg
Copy link
Contributor

muratg commented May 1, 2015

👍

@ChengTian
Copy link
Contributor Author

Talked to @joeloff and confirmed that, as long as the command name is in the form of <any_prefix>-crossgen.cmd, our installer can always find it. So there is no change needed in installer part.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants