Skip to content
This repository has been archived by the owner on Dec 18, 2017. It is now read-only.

dnvm run ... and dnvm exec do not set exit code correctly #428

Closed
dougbu opened this issue Sep 9, 2015 · 3 comments
Closed

dnvm run ... and dnvm exec do not set exit code correctly #428

dougbu opened this issue Sep 9, 2015 · 3 comments
Assignees
Milestone

Comments

@dougbu
Copy link
Member

dougbu commented Sep 9, 2015

dnvm run and dnvm exec do not pass a non-0 exit code from dnx back to the shell. (Side note: This and the _k-test.shade / _k.shade approach means DNX Core tests on Windows can fail without ending the build.)

Repro steps

  1. create a simple Console application that always fails
  2. dnu restore
  3. dnx run
  4. echo %ErrorLevel%`
  • observe expected 1
    1. dnvm run default run or dnvm exec default dnx run
    2. echo %ErrorLevel%
  • observe unexpected 0

Example program

namespace ExitCode
{
    public class Program
    {
        public int Main(string[] args)
        {
            return 1;
        }
    }
}
@muratg
Copy link

muratg commented Sep 9, 2015

@dougbu Is this a regression?

@dougbu
Copy link
Member Author

dougbu commented Sep 9, 2015

I don't think this ever worked correctly. Not sure why we changed KoreBuild as if it did. @BrennanConroy ??

@BrennanConroy
Copy link
Member

4f0b099

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants