Skip to content
This repository has been archived by the owner on Nov 9, 2018. It is now read-only.

Improve Symbol Resolution in TestHost #86

Closed
davidfowl opened this issue Mar 30, 2015 · 7 comments
Closed

Improve Symbol Resolution in TestHost #86

davidfowl opened this issue Mar 30, 2015 · 7 comments

Comments

@davidfowl
Copy link
Member

Found this being used in roslyn http://www.nuget.org/packages/Microsoft.DiaSymReader/1.0.4-rc2

/cc @rynowak

@rynowak
Copy link
Member

rynowak commented Mar 30, 2015

Will take a look. Looks like it's just the COM definitions for https://msdn.microsoft.com/en-us/library/ms233503(v=vs.110).aspx

Will take a look at how they're using it and see if it can address the gaps in our current story.

@Eilon
Copy link
Member

Eilon commented Jul 8, 2015

The real problem here is supporting symbol line info for test cases that use async, iterators, or inherited tests.

We hope that using DiaSymReader or MetadataReader will solve this problem but we're not sure.

@rynowak rynowak changed the title Should we be using Microsoft.DiaSymReader Improve Symbol Resolution in TestHost Aug 5, 2015
@rynowak rynowak added this to the 1.0.0-beta7 milestone Aug 11, 2015
@rynowak rynowak self-assigned this Aug 11, 2015
@rynowak
Copy link
Member

rynowak commented Aug 12, 2015

We ended up not needing MetadataReader to do this. All the info we need is available trivially using reflection.

@rynowak
Copy link
Member

rynowak commented Aug 12, 2015

1941681 8dd3a13

@rynowak rynowak closed this as completed Aug 12, 2015
@gulbanana
Copy link

this problem is still happening for me in 1.0/rtm when there is an async test in a base class.

@rynowak
Copy link
Member

rynowak commented Aug 18, 2016

@gulbanana - please open a new issue on https://github.com/dotnet/cli - they own this functionality now.

@gulbanana
Copy link

ok

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants