This repository has been archived by the owner on Dec 18, 2018. It is now read-only.
Starting HubOptions #743
Merged
Starting HubOptions #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should also work when I call AddSignalR |
moozzyk
reviewed
Aug 21, 2017
| public IHubProtocol GetProtocol(string protocolName, HubConnectionContext connection) | ||
| { | ||
| switch (protocolName?.ToLowerInvariant()) | ||
| { | ||
| case "json": | ||
| return new JsonHubProtocol(new JsonSerializer()); | ||
| return new JsonHubProtocol(JsonSerializer.Create(_options.Value.JsonSerializerSettings)); |
There was a problem hiding this comment.
what settings are used if JsonSerializerSettings is null?
There was a problem hiding this comment.
The default ones. Exact same as what we were doing before.
|
I don't think we can JSON settings defined by the user to serialize/read our payload |
|
It doesn't change any of our items. Example: Sends: We use |
|
Where's the test? |
davidfowl
reviewed
Aug 22, 2017
| @@ -9,6 +10,12 @@ public static class SignalRDependencyInjectionExtensions | |||
| { | |||
| public static ISignalRBuilder AddSignalR(this IServiceCollection services) | |||
| { | |||
| return AddSignalR(services, o => { }); | |||
|
🆙 📅 |
moozzyk
approved these changes
Aug 22, 2017
|
@moozzyk I think so, but we can revisit that after alpha. |
davidfowl
reviewed
Aug 22, 2017
| @@ -36,16 +37,19 @@ public class HubEndPoint<THub> : IInvocationBinder where THub : Hub | |||
| private readonly ILogger<HubEndPoint<THub>> _logger; | |||
| private readonly IServiceScopeFactory _serviceScopeFactory; | |||
| private readonly IHubProtocolResolver _protocolResolver; | |||
| private readonly IOptions<HubOptions> _hubOptions; | |||
There was a problem hiding this comment.
Do we have any concrete things to add here for alpha?
|
Original issue that has a couple items, none look too important #254 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#254 and #261
Wanted to get feedback to see if this is the design we want. Then I'll add a test.
Do we want it to be
HubOptions<THub>?Current usage: