Case issues

[rhegner]

Let's say we have a model like this on the server side:

class Person
{
    public string FirstName { get; set; }
    public string LastName { get; set; }
}

A Asp.Net Core Controller serializes this to a JSON with 'firstName' and 'lastName'. So all my client-side classes use this convention.

I realized that SignalR serializes this to 'FirstName' and 'LastName'. This means I can't re-use my client-side classes.

• Is there an easy way to configure this behaviour in SignalR?
• If not, what's the recommended workaround?
• It would be nice if the default behaviour of SignalR was the same as for Controllers.

[rhegner]

The workaround described here does not seem to work.

[rhegner]

I found a very ugly workaround. In my hub before returning any object I call the following function on it:

private object ToCamelCaseObject(object obj)
{
	var json = JsonConvert.SerializeObject(obj, Formatting.None, SerializerSettings);
	return JsonConvert.DeserializeObject(json);
}
private readonly static JsonSerializerSettings SerializerSettings = new JsonSerializerSettings() { ContractResolver = new Serialization.CamelCasePropertyNamesContractResolver() };

PS (not related to this issue but FYI): issue number 71 seems to be one of the biggest show-stoppers at the moment. Would be nice if arbitrary large objects can be transferred soon!

[radu-matei]

@rhegner What version of SignalR are you using? The article you pointed to was based on the old SignalR repo you can find here - https://github.com/signalr/signalr

Still, could you provide something I can take a look at?

Thanks!

[moozzyk]

@rhegner - the problem is that at the moment we just new up JSonSerializer/JSonTextWriter without allowing passing any options (or maybe resolving these from the DI). We are discussing the best way to resolve #71.
Everything here is pretty much work in progress.

[cruikshj]

I worked around this issue by using my own IInvocationAdapter. It is simply a copy of JsonNetInvocationAdapter (from the repo) but it uses constructor injection to resolve the JsonSerializer rather than newing one up.

public class JsonInvocationAdapter : IInvocationAdapter
{
        public JsonInvocationAdapter(JsonSerializer serializer)
        {
            _serializer = serializer ?? throw new ArgumentNullException(nameof(serializer));
        }

then registering as follows..

var jsonSerializerSettings = new JsonSerializerSettings();
jsonSerializerSettings.ContractResolver = new CamelCasePropertyNamesContractResolver();
jsonSerializerSettings.Formatting = Formatting.Indented;
jsonSerializerSettings.Converters.Add(new StringEnumConverter());
services.AddSingleton(JsonSerializer.Create(jsonSerializerSettings));

services.AddSingleton<JsonInvocationAdapter>();
services.AddSignalR(options =>
{
     options.RegisterInvocationAdapter<JsonInvocationAdapter>("json");
});

[davidfowl]

Tracked by #261