Skip to content
This repository has been archived by the owner on Nov 29, 2018. It is now read-only.

update problem : don't support separate library in new update #275

Closed
pMonfared opened this issue Aug 16, 2016 · 5 comments
Closed

update problem : don't support separate library in new update #275

pMonfared opened this issue Aug 16, 2016 · 5 comments
Assignees

Comments

@pMonfared
Copy link

pMonfared commented Aug 16, 2016

i'm using localization in separate class library and it worked in 1.0.0
but don't work after updated to 1.1.0-alpha1-21873

public class AccountController : Controller
    {
        private readonly IStringLocalizer _stringLocalizer;
        private readonly IHtmlLocalizer _htmlLocalizer;

        private readonly UserManager<ApplicationUser> _userManager;
        private readonly SignInManager<ApplicationUser> _signInManager;
        private readonly IEmailSender _emailSender;
        private readonly ISmsSender _smsSender;
        private readonly ILogger _logger;

        public AccountController(
            IStringLocalizerFactory stringLocalizerFactory,
            IHtmlLocalizerFactory htmlLocalizerFactory,
            UserManager<ApplicationUser> userManager,
            SignInManager<ApplicationUser> signInManager,
            IEmailSender emailSender,
            ISmsSender smsSender,
            ILoggerFactory loggerFactory)
        {
            _stringLocalizer = stringLocalizerFactory.Create(
        baseName: "Controllers.AccountController" ,
        location: "Bookkhan.ExternalResources" );
            _htmlLocalizer = htmlLocalizerFactory.Create(
                baseName: "Controllers.AccountController" ,
                location: "Bookkhan.ExternalResources" );

            _userManager = userManager;
            _signInManager = signInManager;
            _emailSender = emailSender;
            _smsSender = smsSender;
            _logger = loggerFactory.CreateLogger<AccountController>();
        }
...

untitledsss

@pMonfared pMonfared changed the title doesnot support separate library in new update update problem : don't support separate library in new update Aug 16, 2016
@Eilon
Copy link
Member

Eilon commented Sep 11, 2016

Let's see if there's a regression here and if so, we should make sure we add tests before we fix.

@hishamco
Copy link
Contributor

@pMonfared do you have the sample in github repo?

@Eilon
Copy link
Member

Eilon commented Sep 14, 2016

@ryanbrandenburg let's see if we can make this work properly once we do the other fix with the attribute.

@ryanbrandenburg
Copy link
Contributor

@pMonfared this should be fixed by #283 which is merged into dev now? Can you give ResourceLocationAttribute a try and confirm it fixes your situation?

@ryanbrandenburg
Copy link
Contributor

On second thought, what you've said here is pretty much the exact bug we fixed, I'll just close this out and you feel free to reopen it if you're still having trouble.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants