Skip to content
This repository has been archived by the owner on Nov 1, 2018. It is now read-only.

Application Shutdown via IApplicationLifetime should be graceful when behind HttpPlatformHandler #20

Closed
davidfowl opened this issue Oct 24, 2015 · 8 comments

Comments

@davidfowl
Copy link
Member

More details to come...

@davidfowl davidfowl changed the title Application Shutdown via IApplicationShutdown should be graceful when behind HttpPlatformHandler Application Shutdown via IApplicationLifetime should be graceful when behind HttpPlatformHandler Oct 24, 2015
@muratg muratg added this to the 1.0.0-rc2 milestone Nov 20, 2015
@MaximRouiller
Copy link

Any workaround on this? Can we catch and event when a process is being closed?

@muratg
Copy link
Contributor

muratg commented Jan 22, 2016

@davidfowl For RC2 ask mode? Or postpone?

cc @DamianEdwards

@Tratcher
Copy link
Member

Tratcher commented Feb 3, 2016

Design: HttpPlatformHandler will define a new opt-in web.config setting "signalShutdown=true" (verify name). When set, it will send a Ctl+C & Ctl+Break to the back-end process and wait for a given timeout for the process to shut itself down. If the timeout expires then the process will be forcefully terminated.

This feature is being developed as part of the app offline deployment scenario.

@Tratcher
Copy link
Member

Implemented via #81, no setting required.

@moozzyk
Copy link
Contributor

moozzyk commented Mar 16, 2016

👏 for "no setting required"

@muratg
Copy link
Contributor

muratg commented Mar 16, 2016

Nice!

@Tratcher I assume you forgot to close. :)

@muratg muratg closed this as completed Mar 16, 2016
@muratg muratg reopened this Mar 16, 2016
@muratg
Copy link
Contributor

muratg commented Mar 16, 2016

Oh perhaps you're waiting for the full verification before closing. :)

@Tratcher
Copy link
Member

This as been fixed in AspNetCoreModule v0.8: #105.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants