Add ReasonPhrase to HttpResponse

[davidfowl]

Because this code
response.HttpContext.Features.Get<IHttpResponseFeature>().ReasonPhrase = null; is ridiculous

[Tratcher]

No, it's useless &/ obsolete.

The servers will set the reason phrase based on the status code. The application should only ever consider setting it if they are defining custom status codes, and even then it's optional. Most users just set it to the default values anyways.

HTTP/2 has removed this field.

[muratg]

@davidfowl Why do we need this?

[davidfowl]

If we think nobody needs to use it I'm ok punting. As I said:

response.HttpContext.Features.Get<IHttpResponseFeature>().ReasonPhrase = null

Is ridiculous. We pretty much expose everything else on the IHttpResponseFeature.

[Tratcher]

The features are complete / raw protocol, where HttpContext is about convenience. It is part of the protocol, but we have reasons for not making it convenient.

[davidfowl]

Cool. Closing this out until somebody asks for it.