Skip to content
This repository has been archived by the owner on Dec 19, 2018. It is now read-only.

EventNotification support for Hosting #334

Closed
avanderhoorn opened this issue Aug 19, 2015 · 4 comments
Closed

EventNotification support for Hosting #334

avanderhoorn opened this issue Aug 19, 2015 · 4 comments

Comments

@avanderhoorn
Copy link
Member

We want to add support for events via Microsoft.Framework.Notification to various components in Hosting that can be consumed in process by diagnostic tools.

To start with we want to include data/events with known tooling experiences built around them. This isn't a complete list, but includes things we can start on.

Pipeline

  • Begin/End Request - HttpContext
  • Unhandled Exception - HttpContext, Exception

// @rynowak @Tratcher

@Tratcher
Copy link
Member

This seems redundant, you can already put a data gathering middleware at the start of the pipeline (possibly via IStartupFilter) to get this kind of information.

@avanderhoorn
Copy link
Member Author

Same argument could be made for the logging that is there at the moment. Leveraging Event Notifications means we can tap in in a much more consistent way and when you have multiple instrumentation providers all playing in the same sandpit, its not like you are going to end up with a bunch of profiling middleware cluttering your pipeline. Lastly, Event Notifications is going into the BLC and being leveraged by various parts of the platform (ADO, network, IO, Azure SDKs, etc), it seems weird that you can't access a notification for Begin/End Request.

@Eilon
Copy link
Member

Eilon commented Sep 16, 2015

Derp, forgot about this bug. This is now a dup of #354, which is out for PR.

@avanderhoorn
Copy link
Member Author

Sounds good!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants