Updates to simple logging based on design meeting feedback #19235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
requested review from
maumar,
roji,
smitpatel,
AndriySvyryd and
bricelam
AndriySvyryd
reviewed
Dec 9, 2019
AndriySvyryd
approved these changes
Dec 9, 2019
ajcvickers
force-pushed
the
TreeFarm1208
branch
from
347e823
to
d39b54d
Compare
#1199 * Stop exposing the interface in LogTo and replace with delegates overload. * Rename SimpleLoggerFormatOptions to LogToOptions * Similar renaming across the internal implementation
ajcvickers
force-pushed
the
TreeFarm1208
branch
from
d39b54d
to
e16e909
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1199