Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to simple logging based on design meeting feedback #19235

Merged
merged 1 commit into from
Dec 11, 2019
Merged

Updates to simple logging based on design meeting feedback #19235

merged 1 commit into from
Dec 11, 2019

Conversation

ajcvickers
Copy link
Contributor

#1199

  • Stop exposing the interface in LogTo and replace with delegates overload.
  • Rename SimpleLoggerFormatOptions to LogToOptions
    • Similar renaming across the internal implementation

@ajcvickers
Updates to simple logging based on design meeting feedback
e16e909 
#1199

* Stop exposing the interface in LogTo and replace with delegates overload.
* Rename SimpleLoggerFormatOptions to LogToOptions
  * Similar renaming across the internal implementation
@ajcvickers ajcvickers merged commit 7263966 into master Dec 11, 2019
@ajcvickers ajcvickers deleted the TreeFarm1208 branch December 11, 2019 23:29
@ajcvickers ajcvickers mentioned this pull request Dec 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

@maumar maumar Awaiting requested review from maumar

@roji roji Awaiting requested review from roji

@smitpatel smitpatel Awaiting requested review from smitpatel

@bricelam bricelam Awaiting requested review from bricelam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajcvickers @AndriySvyryd