Query: Read Avg/Min/Max as nullable from database to throw exception … #18971
Conversation
…only when it is empty Resolves #18955
|
Description Customer Impact How found Test coverage Regression? Risk |
|
@Pilchie FYI, we would like to patch this in 3.1.1. |
|
What workaround is available to the customer, if any? |
|
@Pilchie Having a workaround may not help much in this case. The issue is that if you are calculating the max of a set of values, then your application may work fine until the result happens to be zero at which point the app will crash. To use a workaround you would have to know that the issue exists, which is very easily missed here, even with reasonable testing. |
| @@ -55,6 +56,10 @@ protected override RelationalTypeMapping Clone(RelationalTypeMappingParameters p | |||
| /// The generated string. | |||
| /// </returns> | |||
| protected override string GenerateNonNullSqlLiteral(object value) | |||
| => ((float)value).ToString("R", CultureInfo.InvariantCulture); | |||
| { | |||
| var floatValue = Convert.ToSingle(value); | |||
PR Feedback
…only when it is empty
Resolves #18955