Catch exceptions in CanConnect and return false #18867
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18355
We can consider logging the exceptions, although I'm not sure that would be the right thing to do - this method is purely about checking whether we can connect or not, and it could be said there's no actual "failing operation" warranting a log message. It would also likely cause lots of spurious log messages as automated health checks fail while networking is down etc.
Note that I don't think this is a breaking change, as applications are already expected to check for false.