Fix conditional and null-coalescing handling in parameter extraction #18640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @Pilchie |
roji
force-pushed
the
ConditionalEvaluation
branch
from
2ceddf5 to
c059579
Compare
smitpatel
approved these changes
Oct 29, 2019
roji
force-pushed
the
ConditionalEvaluation
branch
from
c059579 to
0cb231a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't visit conditional true or false nodes as appropriate if test evalutes to constant.
Also don't visit right-hand side of null-coalescing expression if left-hand side evaluates to non-null.
Fixes #17942
Fixes #13859