Reset relationship uniqueness when removing the navigation to dependent. #18521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
approved these changes
Oct 22, 2019
|
I was too optimistic. Tests seemed to pass locally because I didn't see the debug asserts failing |
AndriySvyryd
force-pushed
the
Issue15512
branch
from
e0cb722 to
6907147
Compare
AndriySvyryd
commented
Oct 22, 2019
| @@ -43,6 +43,6 @@ public ConventionAnnotation([NotNull] string name, [CanBeNull] object value, Con | |||
| /// doing so can result in application failures when updating to a new Entity Framework Core release. | |||
| /// </summary> | |||
| public virtual ConfigurationSource UpdateConfigurationSource(ConfigurationSource configurationSource) | |||
| => _configurationSource = _configurationSource.Max(configurationSource); | |||
| => _configurationSource = configurationSource.Max(_configurationSource); | |||
There was a problem hiding this comment.
No functional impact, just consistency
smitpatel
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15512