Add SELECT 1 check to Exists/CanConnect checks #18508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why the additional logging? |
|
@ErikEJ what do you mean? |
|
The call to .ExecuteNonQuery - but maybe it always is logged? |
|
Yeah, the call is logged like any other command execution (assuming you've enabled it etc.). Do you see an issue here? We can specifically exempt logging this command, but I'm not sure whether that would be the right thing to do (see also comment in the OP). |
src/EFCore.SqlServer/Storage/Internal/SqlServerDatabaseCreator.cs
Outdated
Show resolved
Hide resolved
roji
force-pushed
the
ExistsSelectCheck
branch
from
2e5839e to
fd4cd15
Compare
AndriySvyryd
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18330
Note that the connection.Open operation has passes
errorsExpected: true, so that connection errors are logged as debug. We can do this for theSELECT 1command as well, but I think the main idea here is to squash "does not exist" errors specifically, which really aren't an error. Other types of errors (e.g. connectivity) still seem like they should log an error, since it's not a matter of the database not being created. But if someone thinks otherwise I can adderrorsExpectedto command failure logging.