Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query: Support ICollection<T>.Contains #17599

Merged
merged 2 commits into from
Sep 3, 2019
Merged

Query: Support ICollection<T>.Contains #17599

merged 2 commits into from
Sep 3, 2019

Conversation

smitpatel
Copy link
Contributor

Additional PR to clean up #17469
Also re-targeted to release/3.1

@wdnijdam
Copy link

This change does not work for Support IReadOnlyCollection.Contains()

IReadOnlyCollection is translated correctly by EF core 2.2. It would make more sense to translate IReadOnlyCollection since it covers ICollection and Array as well.

@smitpatel
Copy link
Contributor Author

@wdnijdam - Your issue is unrelated to this.

@gojanpaolo
Copy link

Hello, is there an issue for having the following query translated by ef core?

var words = new[] { "foo", "bar" };
ctx.Post.Where(p => words.Any(p.Title.Contains));

This is the closest related issue I could find, but I'm pretty sure there is already an issue for this, I just don't know the terms to search for. Thanks!

@wdnijdam
Copy link

wdnijdam commented Mar 31, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants