Entity equality: fix mis-identification as collection navigation #17447
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
reviewed
Aug 27, 2019
| @@ -959,24 +959,15 @@ private Expression CreatePropertyAccessExpression(Expression target, IProperty p | |||
| } | |||
|
|
|||
| private static bool CanEvaluate(Expression expression) | |||
| { | |||
| switch (expression) | |||
| => expression switch | |||
There was a problem hiding this comment.
@smitpatel 💔 switch expressions 
There was a problem hiding this comment.
Will revert, but any specific reason you don't like it here?
There was a problem hiding this comment.
Involves processing more than mere a single line. Kills readability.
smitpatel
approved these changes
Aug 27, 2019
We now flow the last navigation only for pure traversal (via member, EF.Property) and not for Select and others. This corrects valid entity references which were misidentified as collection navigations. Fixes #17229
roji
force-pushed
the
EntityEqualityNavigationFix
branch
from
3cfd068
to
0b5fb84
Compare
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now flow the last navigation only for pure traversal (via member, EF.Property) and not for Select and others. This corrects valid entity references which were misidentified as collection navigations.
Fixes #17229