Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[preview9] Clean up Metadata API #17357

Merged
merged 1 commit into from
Aug 21, 2019
Merged

[preview9] Clean up Metadata API #17357

merged 1 commit into from
Aug 21, 2019

Conversation

AndriySvyryd
Copy link
Member

No description provided.

ajcvickers
ajcvickers reviewed Aug 21, 2019
View reviewed changes
src/EFCore/Extensions/ConventionModelExtensions.cs
@@ -27,7 +28,7 @@ public static IConventionEntityType FindEntityType([NotNull] this IConventionMod

/// <summary>
/// Gets the entity type for the given name, defining navigation name
/// and the defining entity type. Returns null if no matching entity type is found.
/// and the defining entity type. Returns <c>null</c> if no matching entity type is found.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:trollface:

@AndriySvyryd AndriySvyryd merged commit 85a93ec into release/3.0-preview9 Aug 21, 2019
@ghost ghost deleted the MetadataAPICleanup branch August 21, 2019 19:00
@smitpatel
Copy link
Member

Build failed or passed?

@smitpatel smitpatel restored the MetadataAPICleanup branch August 21, 2019 19:08
@smitpatel smitpatel deleted the MetadataAPICleanup branch August 21, 2019 19:09
@ajcvickers
Copy link
Member

@AndriySvyryd Build failure:

xUnit.net Console Runner v2.4.1 (64-bit .NET Core 3.0.0-preview9-19416-02)
  Discovering: Microsoft.EntityFrameworkCore.InMemory.Tests
  Discovered:  Microsoft.EntityFrameworkCore.InMemory.Tests
  Starting:    Microsoft.EntityFrameworkCore.InMemory.Tests
Stack overflow.
Stack overflow.
=== COMMAND LINE ===
"C:\aspnet\EntityFrameworkCore\.dotnet\dotnet.exe" exec --depsfile "C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.InMemory.Tests\Debug\netcoreapp3.0\Microsoft.EntityFrameworkCore.InMemory.Tests.deps.json" --runtimeconfig "C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.InMemory.Tests\Debug\netcoreapp3.0\Microsoft.EntityFrameworkCore.InMemory.Tests.runtimeconfig.json"  "C:\Users\avickers\.nuget\packages\xunit.runner.console/2.4.1/tools/netcoreapp2.0/xunit.console.dll" "C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.InMemory.Tests\Debug\netcoreapp3.0\Microsoft.EntityFrameworkCore.InMemory.Tests.dll" -noautoreporters -xml "C:\aspnet\EntityFrameworkCore\artifacts\TestResults\Debug\EFCore.InMemory.Tests_netcoreapp3.0_x64.xml" -html "C:\aspnet\EntityFrameworkCore\artifacts\TestResults\Debug\EFCore.InMemory.Tests_netcoreapp3.0_x64.html"  > "C:\aspnet\EntityFrameworkCore\artifacts\log\Debug\EFCore.InMemory.Tests_netcoreapp3.0_x64.log" 2>&1

@smitpatel smitpatel mentioned this pull request Aug 21, 2019
Merged
@ajcvickers ajcvickers mentioned this pull request Aug 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajcvickers ajcvickers ajcvickers approved these changes

Assignees
No one assigned
Labels
tell-mode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndriySvyryd @smitpatel @ajcvickers @dougbu