Relational: Populate collections in projection before calling into client code #17219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
requested review from
ajcvickers,
maumar,
AndriySvyryd,
roji and
bricelam
ajcvickers
approved these changes
Aug 17, 2019
…ient code The shapers on relational now take ResultContext which stores object[] of temporary values. Then populate the collection fully. Then call into client code to generate final result. Resolves #16318
smitpatel
force-pushed
the
smit/ThisIsHardToFixBug
branch
from
8fcd992 to
881c3a5
Compare
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shapers on relational now take ResultContext which stores object[] of temporary values. Then populate the collection fully. Then call into client code to generate final result.
Resolves #16318