Rename provider specific core metadata extensions #16824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
approved these changes
Jul 29, 2019
Fixes #16773 Note going through obsolete here since this are a lot less used.
ajcvickers
force-pushed
the
BeurocraticUpupa0729c
branch
from
73cf39b
to
714e6ba
Compare
ghost
deleted the
bricelam
reviewed
Jul 29, 2019
| => property.FindAnnotation(SqliteAnnotationNames.Srid)?.GetConfigurationSource(); | ||
|
|
||
| /// <summary> | ||
| /// Returns the dimension to use when creating a column for this property. | ||
| /// </summary> | ||
| /// <param name="property"> The property. </param> | ||
| /// <returns> The dimension to use when creating a column for this property. </returns> | ||
| public static string GetSqliteDimension([NotNull] this IProperty property) | ||
| public static string GetSpatialDimension([NotNull] this IProperty property) |
There was a problem hiding this comment.
I have a slight preference for geometry dimension (builder APIs too)
There was a problem hiding this comment.
(or possibly geometric if it grammars better)
There was a problem hiding this comment.
Significant. Neither NTS nor SpaiaLite use the word spatial in their APIs
ajcvickers
added a commit
that referenced
this pull request
Jul 30, 2019
ajcvickers
added a commit
that referenced
this pull request
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16773
Note going through obsolete here since this are a lot less used.