Don't persist keys for embedded entities #16779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
force-pushed
the
CosmosOrdinals2
branch
from
0eaa5b2 to
d4d422b
Compare
AndriySvyryd
changed the title
|
This is ready for review now |
AndriySvyryd
force-pushed
the
CosmosOrdinals2
branch
from
d4d422b to
8f50ca5
Compare
ajcvickers
reviewed
Jul 27, 2019
ajcvickers
approved these changes
Jul 27, 2019
AndriySvyryd
force-pushed
the
CosmosOrdinals2
branch
from
8f50ca5 to
f0ad142
Compare
AndriySvyryd
force-pushed
the
CosmosOrdinals2
branch
from
f0ad142 to
5a44a8a
Compare
ghost
deleted the
|
@smitpatel Please review this when you are able |
smitpatel
reviewed
Jul 30, 2019
smitpatel
reviewed
Jul 30, 2019
smitpatel
reviewed
Jul 30, 2019
| array.Add(_database.GetDocumentSource(dependentEntry.EntityType).CreateDocument(dependentEntry)); | ||
| var embeddedDocument = embeddedDocumentSource.GetCurrentDocument(embeddedEntry); | ||
| embeddedDocument = embeddedDocument != null | ||
| ? embeddedDocumentSource.UpdateDocument(embeddedDocument, embeddedEntry) ?? embeddedDocument |
There was a problem hiding this comment.
Why this uses coalesce but reference navigation is not using?
There was a problem hiding this comment.
We need to add all entities to the collection in order even if they weren't updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The store JObject is now stored in a shadow property for embedded entities as well to allow to keep unmapped properties.
Fixes #13578
Part of #12086