Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tiny: allow CaseExpression with operand and else clause #16726

Merged
merged 1 commit into from
Jul 24, 2019
Merged

Tiny: allow CaseExpression with operand and else clause #16726

merged 1 commit into from
Jul 24, 2019

Conversation

roji
Copy link
Member

@roji roji commented Jul 24, 2019

No description provided.

@roji roji requested a review from smitpatel July 24, 2019 16:50
@smitpatel
Copy link
Contributor

It does not make sense. What is the Sql expression tree you are constructing?

@roji
Copy link
Member Author

roji commented Jul 24, 2019 •
edited
Loading

It's supported in SQL both by SQL Server (the "simple case expression") and PostgreSQL (again "simple form").

The specific translation where I could use this is to return a number, but to translate 0 into 7 (this actually happens in PostgreSQL when translating DayOfWeek which returns an enum). I could generate CASE value WHEN 0 THEN 7 ELSE value END.

smitpatel
smitpatel suggested changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@smitpatel smitpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor error.
Everything else looks fine.

src/EFCore.Relational/Query/Pipeline/SqlExpressionFactory.cs Outdated Show resolved Hide resolved
@roji roji force-pushed the CaseOperandElse branch from d6bf392 to a300f4c Compare July 24, 2019 19:26
@roji roji requested a review from smitpatel July 24, 2019 19:26
@roji roji force-pushed the CaseOperandElse branch from a300f4c to 0d7af8b Compare July 24, 2019 22:58
@roji roji merged commit 1d27fd8 into master Jul 24, 2019
@ghost ghost deleted the CaseOperandElse branch July 24, 2019 23:30
@ajcvickers ajcvickers mentioned this pull request Jul 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smitpatel smitpatel smitpatel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roji @smitpatel