Make SqlExpressionFactory.ApplyTypeMapping virtual #16550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plus some C# 8 goodness
smitpatel
approved these changes
Jul 10, 2019
smitpatel
reviewed
Jul 10, 2019
| { | ||
| if (sqlExpression == null | ||
| || sqlExpression.TypeMapping != null) | ||
| { | ||
| return sqlExpression; | ||
| } | ||
|
|
||
| switch (sqlExpression) | ||
| return sqlExpression switch |
There was a problem hiding this comment.
Just a side note:
We have no consensus on if we want to use switch expression everywhere. In certain cases, it seems useful but in other cases it also hinders readability. It will show up in design meeting at some point.
There was a problem hiding this comment.
OK, no problem. I also don't think using them everywhere is a good idea - it's a case-by-case thing. Feel free to reject changes if you feel they're detrimental.
/cc @ajcvickers
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Providers can be expected to extend SqlExpressionFactory in order to facilitate creating custom SQL expressions. The ApplyTypeMapping in particular should be virtual to allow it to be overridden for those expressions. Other methods don't seem to require extensibility, but we can discuss.
Also did some C# 8 goodness.