Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview7: Remove cancellation token from Close APIs #16396

Merged
merged 1 commit into from
Jul 2, 2019
Merged

Preview7: Remove cancellation token from Close APIs #16396

merged 1 commit into from
Jul 2, 2019

Conversation

ajcvickers
Copy link
Contributor

Fixes #16353

@ajcvickers
Copy link
Contributor Author

This is approved for preview7

smitpatel
smitpatel approved these changes Jul 2, 2019
View reviewed changes
Copy link
Contributor

@smitpatel smitpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ajcvickers ajcvickers merged commit 32ff2d1 into release/3.0-preview7 Jul 2, 2019
@ghost ghost deleted the Halo09 branch July 2, 2019 17:57
@ajcvickers ajcvickers mentioned this pull request Jul 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smitpatel smitpatel smitpatel approved these changes

@roji roji Awaiting requested review from roji

@AndriySvyryd AndriySvyryd Awaiting requested review from AndriySvyryd

@bricelam bricelam Awaiting requested review from bricelam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajcvickers @smitpatel