Verified bug #15684 is fixed #16338
Merged
Verified bug #15684 is fixed #16338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
reviewed
Jun 28, 2019
smitpatel
reviewed
Jun 28, 2019
smitpatel
approved these changes
Jun 28, 2019
There was a problem hiding this comment.
I think we should still have code review even just a test.
Query has following components
- Compilation
- Execution
- Result verification
- Entity tracking
- Generated SQL
AssertQuery syntax verifies all. But others may not and it's better to have someone to review if the test is verifying correct results.
|
No problem for continuing to send PRs. However, although in principle I agree it's a good idea to always assert SQL, with everything going on I'm not sure it's that valuable on these bug tests (especially since we no longer have client eval). We already have lots of tests with no SQL assert... Anyway, will do. |
Projection not working correctly when using the EnumToStringConverter Fixes #15684
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repro'd bug in 2.2.5 and confirmed it is gone in latest bits, added QueryBugTest.
Fixes #15684
@smitpatel @ajcvickers for these cases where there's only a new test, do you still want to sign off on PRs? It would give you visibility on work but otherwise may not be very useful.