Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor query SQL generation for standardization #16136

Merged
merged 1 commit into from
Jun 18, 2019
Merged

Refactor query SQL generation for standardization #16136

merged 1 commit into from
Jun 18, 2019

Conversation

roji
Copy link
Member

@roji roji commented Jun 18, 2019

  • GenerateTop() implementation moved to SqlServer
  • GenerateLimitOffset() generates ISO SQL:2008 by default, overridden by SqlServer (and Sqlite)

@roji
Refactor query SQL generation for standardization
f52355f 
* GenerateTop() implementation moved to SqlServer
* GenerateLimitOffset() generates ISO SQL:2008 by default, overridden
  by SqlServer (and Sqlite)
@roji roji requested a review from dougbu as a code owner June 18, 2019 15:19
smitpatel
smitpatel reviewed Jun 18, 2019
View reviewed changes
src/EFCore.Relational/Query/Pipeline/QuerySqlGenerator.cs
@@ -562,6 +555,15 @@ protected virtual void GenerateLimitOffset(SelectExpression selectExpression)
_relationalCommandBuilder.Append(" ROWS ONLY");
}
}
else if (selectExpression.Limit != null)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DRY with above block.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note the different between FETCH FIRST and FETCH NEXT... Doesn't seem worth DRYing...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One line difference was reason for DRYing

@roji roji merged commit df9e419 into master Jun 18, 2019
@ghost ghost deleted the SqlGeneratorStandard branch June 18, 2019 15:36
@ajcvickers ajcvickers mentioned this pull request Jun 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smitpatel smitpatel smitpatel approved these changes

@dougbu dougbu Awaiting requested review from dougbu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roji @smitpatel