Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServer Spatial: Enable calling methods on parameterized values #16097

Merged
merged 2 commits into from
Jul 9, 2019
Merged

SqlServer Spatial: Enable calling methods on parameterized values #16097

merged 2 commits into from
Jul 9, 2019

Conversation

bricelam
Copy link
Contributor

@bricelam bricelam commented Jun 14, 2019

Fixes #14595

@divega Looks like dotnet/corefx#36678 isn't in Microsoft.Data.SqlClient. Tests pass after reverting 10e553a (resolved)

@"@__point_0='0xE6100000010C000000000000F03F0000000000000000' (Nullable = false) (Size = 22) (DbType = Object)

SELECT [g].[Id], @__point_0.STDistance([g].[Location]) AS [Distance]
FROM [GeoPointEntity] AS [g]");
Copy link
Contributor Author

@bricelam bricelam Jun 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 @Wraith2 you rock! (no System.Data.SqlTypes)

@bricelam bricelam requested a review from dougbu as a code owner July 9, 2019 16:59
@bricelam bricelam removed the blocked label Jul 9, 2019
@bricelam
Copy link
Contributor Author

bricelam commented Jul 9, 2019

Unblocked by #16527 🎉

@bricelam bricelam requested a review from ajcvickers July 9, 2019 17:09
@bricelam bricelam merged commit 99e1606 into dotnet:master Jul 9, 2019
@bricelam bricelam deleted the lhs branch July 9, 2019 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqlServer Spatial: Cannot call methods on varbinary
2 participants