[TINY] Fix to #15763 - "collection selector was not NavigationExpansionExpression" when joining two FromSql()s #15963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
reviewed
Jun 5, 2019
src/EFCore/Query/NavigationExpansion/Visitors/NavigationExpandingVisitor_MethodCall.cs
Outdated
Show resolved
Hide resolved
|
new version up |
maumar
force-pushed
the
fix15763
branch
2 times, most recently
from
673f778
to
0c7b64f
Compare
smitpatel
reviewed
Jun 7, 2019
| // result is a sequence, no lambda arguments, exactly one generic argument corresponding to result sequence type | ||
| if (methodCallExpression.Object == null | ||
| && resultSequenceType != null | ||
| && methodCallExpression.Arguments.All(a => a.UnwrapQuote() == null) |
There was a problem hiding this comment.
Use a different function to identify if it is a lambda. UnwrapQuote needs to return LambdaExpression only, never null;
smitpatel
approved these changes
Jun 7, 2019
…ssion" when joining two FromSql()s Problem was that navigation expansion wasn't recognizing FromSqlOnQueryable as something that needs to be visited, so the expression was not being converted to NavigationExpansionExpression. SelectMany requires collection navigation to be a NavigationExpansionExpression, hence the error. Fix is to add generic handling of simple queryable methods.
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem was that navigation expansion wasn't recognizing FromSqlOnQueryable as something that needs to be visited, so the expression was not being converted to NavigationExpansionExpression.
SelectMany requires collection navigation to be a NavigationExpansionExpression, hence the error.