Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trs79 master #967

Merged
merged 9 commits into from
Jul 2, 2019
Merged

Trs79 master #967

merged 9 commits into from
Jul 2, 2019

Conversation

ajcvickers
Copy link
Member

Rebased PR

…te functions.

The first argument does still need to be a collection type, however.
- Added overloads to not break public API
- Updated summary text
- Disable optimization for aggregate functions with multiple arguments
- Simplified LINQ expression
…nd removed more code that was enforcing only one argument
…usly removed (now checks for greater then or equal to 1, instead of just 1)

- More formatting cleanup

- Added missing aggregate function in Ssdl
@ajcvickers ajcvickers merged commit e6af77b into master Jul 2, 2019
@ghost ghost deleted the trs79-master branch July 2, 2019 14:12
@bricelam
Copy link
Contributor

bricelam commented Jul 3, 2019

@ajcvickers You can force-push to other people's PRs to avoid creating new ones.

@ajcvickers
Copy link
Member Author

@bricelam Tried that, but couldn't make it work.

@bricelam
Copy link
Contributor

bricelam commented Jul 3, 2019

Ah, users have the option to disable it. It was also disabled for any PRs opened before the feature was added.

@ajcvickers
Copy link
Member Author

Or I was just doing it wrong...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants