Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fortunes endpoint that returns RazorComponentResult to the Minimal project #2041

Merged
merged 4 commits into from
Dec 19, 2024

Conversation

DamianEdwards
Copy link
Member

This will allow for easy investigation of performance differences between:

Also added a way to run Fortunes in the Minimal project without a database (similar to what we have in Platform) to more directly compare the rendering stacks.

For the RazorComponentResult there's a commented-out line that uses a custom parameters struct that implements IReadOnlyDictionary<string, object?> to pass the model to the component to avoid allocating a Dictionary<string, object?> on every request. Figured it was interesting to leave that there for whomever takes up doing deeper analysis here.

/Cc @javiercn

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • src/BenchmarksApps/TechEmpower/Minimal/Templates/FortunesRazor.razor: Evaluated as low risk
  • src/BenchmarksApps/TechEmpower/Minimal/Templates/_Imports.razor: Evaluated as low risk
@DamianEdwards DamianEdwards merged commit 9b5402f into main Dec 19, 2024
2 checks passed
@sebastienros sebastienros deleted the FortunesRazorComponentResult branch December 19, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants