Reason behind instrumentation-neo4j locked behind versions >=4.0.0 <5.0.0 of neo4j-driver

[bokjo]

Hello,

General question on why the instrumentation-neo4j package is locked behind versions >=4.0.0 <5.0.0 of the neo4j-driver?

In my understanding, the neo4j-driver@v5 is fully backward compatible with the v4 one.

Did a quick test, hardcoding the check in the lib like this

    this.getModuleDefinition('neo4j-driver-core', ['>=4.3.0 <=5']),
    this.getModuleDefinition('neo4j-driver', ['>=4.0.0 <=5']),

in the Instrumentation init() function
https://github.com/aspecto-io/opentelemetry-ext-js/blob/master/packages/instrumentation-neo4j/src/neo4j.ts#L30

and everything seems to be working as expected (the traces are generated successfully and sent to the appropriate exporter's backend)

If some additional testing is needed please let me know!

[blumamir]

This version was removed in #243 since the automatic tests failed for this version.

I don't know what changes are required, but if you have time to do the research and make it work, please open a PR and we will be happy to merge and publish it :)

[bokjo]

Hello, thanks for the reply.

Can you point me to the failing test you are referring to and what should be addressed in more detail?

I might have some time this week to take a look ( think the same goes for the Elastic (>v5) package as well)

Regards,
Che

[shakeelsoogun]

Hey all, can see the version lock is still in place for "< 5.0.0". Was there any update on whether this can be removed or not?

[ChrisEnglert]

We're using a fork with <=5 removed from getModuleDefinition ...
It works for us with
"neo4j-driver": "5.17.0"