Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

sequelize: Suggest better regex for opentelemetry-instrumentation-sequelize/utils.js extractTableFromQuery #253

Open
ray58750034 opened this issue Dec 29, 2022 · 0 comments

Comments

@ray58750034
Copy link

ray58750034 commented Dec 29, 2022

Original code: https://github.com/aspecto-io/opentelemetry-ext-js/blob/master/packages/instrumentation-sequelize/src/utils.ts#L3

Suggest regex:

query.match(/(?<=(update|(?<!distinct\s+)from|join|truncate|into)\s+)\"?\`?(\w+)\"?\`?/gi);

Expect to work with following sqls:

UPDATE tableName SET field=value;
INSERT INTO tableName ("field") VALUES (value);
SELECT * FROM tableName WHERE field IS DISTINCT FROM value;
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant